ref(chat): make Conversation API turns native - #1703
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dashboard visual evidenceMode: path-selected Triggered by:
Component gallery index · desktop
Conversations · desktop
Conversations · mobile
Conversation detail · desktop
Conversation detail · mobile
Conversation detail · focused composer · mobile
Full-page screenshots from the mock dashboard. Not a pixel-diff gate. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ec98964. Configure here.
| // Drop the connect prompt so a replaced OAuth flow | ||
| // cannot leave a stale banner after the user moves on. | ||
| await deleteWebAuthorization({ | ||
| await deleteApiAuthorization({ |
There was a problem hiding this comment.
Auth delete skips legacy actor key
Medium Severity
Superseding an auth-paused Turn deletes the pending authorization only under the current Actor id. Parked prompts from before the identity change still live under the legacy dashboard: Actor id, so getApiAuthorization keeps finding them and the connect banner remains after the Turn is abandoned.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ec98964. Configure here.
1 participant
Conversation API Turns now enter the shared runtime as Junior work. Their Actor is the signed-in user, and their Source and Destination name the Junior Conversation. A continued Slack Conversation keeps its Slack Location, but the API reply stays in the Conversation log and is not sent to Slack.
The change also gives API Messages and Turns stable UUIDs, preserves the active Actor across authorization and process resumes, and lets authorization callbacks recover the current Destination from stored Conversation routing. Existing
webSource and Actor values, credential keys, and pending authorization requests remain readable during the dated migration period.The main review risk is resume behavior across old and new stored identity data. Integration coverage exercises API creation and continuation, ACP, cancellation, authorization resume, legacy credentials, pending messages, and Slack Location preservation.
Refs #1563